git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
forgejo/models/repo
History
Gusted 511148dbc3 perf: avoid sorting team names for ComposeMetas (#7223) 
- `ComposeMetas` is called to compose meta information for the markdown processer (which is called a lot), one of those information is the team names that have access to the repository. This is used to decide if a mention is a team mention or not.
- The SQL query sorts the names, this is unnecessary and not required for within the processer; it does a simple `strings.Contains(teams, ","+teamName+",")`, which doesn't rely on sorted values.
- Doing the SQL query with sorting against Codeberg's MariaDB took ~0.180s and without sorting took ~0.03s. Although the returned values are often a few rows (the query I tested returned 8 values) it seems that doing any sorting will create an temporary index and is mainly optimized where it has to sort a huge amount of rows.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7223
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
2025-03-17 09:00:12 +00:00
..
TestSearchRepositoryIDsByCondition fix: anomynous users code search for private/limited user's repository 2024-11-15 10:59:36 +01:00
archive_download_count.go chore: fix typos, decap a few i18n strings (#6666) 2025-01-24 05:41:59 +00:00
archive_download_count_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
archiver.go Count downloads for tag archives 2024-04-08 12:51:27 +02:00
attachment.go chore: Remove DeleteAttachmentsByIssue 2025-01-30 12:19:59 +01:00
attachment_test.go chore: Remove DeleteAttachmentsByIssue 2025-01-30 12:19:59 +01:00
avatar.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
collaboration.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
collaboration_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
following_repo.go ui for adding following repos 2024-05-24 13:28:15 +02:00
following_repo_test.go ui for adding following repos 2024-05-24 13:28:15 +02:00
fork.go fix: don't show private forks in forks list 2024-11-15 10:59:36 +01:00
fork_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
git.go feat: allow changing default branch update style 2024-12-23 18:55:25 +03:00
issue.go Clean up log messages (#30313) 2024-04-15 20:01:35 +02:00
language_stats.go chore: remove usages of sort.Sort (#6689) 2025-01-26 13:30:00 +00:00
language_stats_test.go chore: remove usages of sort.Sort (#6689) 2025-01-26 13:30:00 +00:00
main_test.go tests: improve actvititypub integration test code 2024-11-01 22:39:49 +01:00
mirror.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
pushmirror.go [FEAT] Allow pushmirror to use publickey authentication 2024-08-22 17:05:07 +02:00
pushmirror_test.go [FEAT] Allow pushmirror to use publickey authentication 2024-08-22 17:05:07 +02:00
redirect.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
redirect_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
release.go linting: fix typos, add toml validation (#7007) 2025-02-21 08:23:03 +00:00
release_test.go Update 2024-12-30 17:47:34 +01:00
repo.go perf: avoid sorting team names for ComposeMetas (#7223) 2025-03-17 09:00:12 +00:00
repo_flags.go [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
repo_flags_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
repo_indexer.go Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
repo_list.go chore: Remove FindReposMapByIDs 2025-01-30 12:19:59 +01:00
repo_list_test.go fix: anomynous users code search for private/limited user's repository 2024-11-15 10:59:36 +01:00
repo_repository.go ui for adding following repos 2024-05-24 13:28:15 +02:00
repo_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
repo_unit.go feat: allow changing default branch update style 2024-12-23 18:55:25 +03:00
repo_unit_test.go feat: allow changing default branch update style 2024-12-23 18:55:25 +03:00
search.go fix: Add recentupdated as recognized sort option 2024-10-19 23:53:29 +02:00
star.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
star_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
topic.go chore: Remove GetTopicByName 2025-01-30 12:19:59 +01:00
topic_test.go chore: Remove GetTopicByName 2025-01-30 12:19:59 +01:00
update.go Move some repository transfer functions to service layer (#28855) 2024-02-05 06:17:23 +00:00
upload.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
user_repo.go fix: make author search case insenstive (#6782) 2025-02-04 16:33:47 +00:00
user_repo_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
watch.go [MODERATION] Refactor excluding watchers mechanism (squash) 2024-02-05 15:56:58 +01:00
watch_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
wiki.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00