git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions4
forgejo/models/migrations/fixtures/Test_AddRepoIDForAttachment
History
Lunny Xiao 97c8dbf332
Fix bug hidden on CI and make ci failed if tests failure () 
The tests on migration tests failed but CI reports successfully

2004468596 (step):8:141

This PR will fix the bug on migration v283 and also the CI hidden
behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

This also fix 

(cherry picked from commit 45277486c2c6213b7766b1da708a991cdb1f3565)

Conflicts:
	.github/workflows/pull-db-tests.yml
	Makefile
	models/migrations/v1_22/v283.go
	models/migrations/v1_22/v286_test.go
	models/migrations/v1_22/v287_test.go
	already in Forgejo for the Makefile & CI logic but Gitea changes
	otherwise rule
2024-03-11 23:36:59 +07:00
..
attachment.yml Fix bug hidden on CI and make ci failed if tests failure () 2024-03-11 23:36:59 +07:00
issue.yml Fix bug hidden on CI and make ci failed if tests failure () 2024-03-11 23:36:59 +07:00
release.yml Fix bug hidden on CI and make ci failed if tests failure () 2024-03-11 23:36:59 +07:00