 05273fa8d2
			
		
	
	
	05273fa8d2
	
	
	
		
			
			This PR depends on https://codeberg.org/forgejo/forgejo/pulls/7510 This PR renames UpdateRunJob to UpdateRunJobWithoutNotification and UpdateRun to UpdateRunWithoutNotification and implements wrapper functions that also call the new ActionRunNowDone notification when needed. This PR can be reviewed commit-by-commit. # Things to Test - [x] GetRunBefore - [ ] integration test for sendActionRunNowDoneNotificationIfNeeded, UpdateRun and UpdateRunJob ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Co-authored-by: nobody <nobody@example.com> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7491 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: christopher-besch <mail@chris-besch.com> Co-committed-by: christopher-besch <mail@chris-besch.com>
		
			
				
	
	
		
			199 lines
		
	
	
	
		
			5.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			199 lines
		
	
	
	
		
			5.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2022 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package actions
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"slices"
 | |
| 	"time"
 | |
| 
 | |
| 	"forgejo.org/models/db"
 | |
| 	"forgejo.org/modules/container"
 | |
| 	"forgejo.org/modules/timeutil"
 | |
| 	"forgejo.org/modules/util"
 | |
| 
 | |
| 	"xorm.io/builder"
 | |
| )
 | |
| 
 | |
| // ActionRunJob represents a job of a run
 | |
| type ActionRunJob struct {
 | |
| 	ID                int64
 | |
| 	RunID             int64      `xorm:"index"`
 | |
| 	Run               *ActionRun `xorm:"-"`
 | |
| 	RepoID            int64      `xorm:"index"`
 | |
| 	OwnerID           int64      `xorm:"index"`
 | |
| 	CommitSHA         string     `xorm:"index"`
 | |
| 	IsForkPullRequest bool
 | |
| 	Name              string `xorm:"VARCHAR(255)"`
 | |
| 	Attempt           int64
 | |
| 	WorkflowPayload   []byte
 | |
| 	JobID             string   `xorm:"VARCHAR(255)"` // job id in workflow, not job's id
 | |
| 	Needs             []string `xorm:"JSON TEXT"`
 | |
| 	RunsOn            []string `xorm:"JSON TEXT"`
 | |
| 	TaskID            int64    // the latest task of the job
 | |
| 	Status            Status   `xorm:"index"`
 | |
| 	Started           timeutil.TimeStamp
 | |
| 	Stopped           timeutil.TimeStamp
 | |
| 	Created           timeutil.TimeStamp `xorm:"created"`
 | |
| 	Updated           timeutil.TimeStamp `xorm:"updated index"`
 | |
| }
 | |
| 
 | |
| func init() {
 | |
| 	db.RegisterModel(new(ActionRunJob))
 | |
| }
 | |
| 
 | |
| func (job *ActionRunJob) Duration() time.Duration {
 | |
| 	return calculateDuration(job.Started, job.Stopped, job.Status)
 | |
| }
 | |
| 
 | |
| func (job *ActionRunJob) LoadRun(ctx context.Context) error {
 | |
| 	if job.Run == nil {
 | |
| 		run, err := GetRunByID(ctx, job.RunID)
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 		job.Run = run
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // LoadAttributes load Run if not loaded
 | |
| func (job *ActionRunJob) LoadAttributes(ctx context.Context) error {
 | |
| 	if job == nil {
 | |
| 		return nil
 | |
| 	}
 | |
| 
 | |
| 	if err := job.LoadRun(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	return job.Run.LoadAttributes(ctx)
 | |
| }
 | |
| 
 | |
| func (job *ActionRunJob) ItRunsOn(labels []string) bool {
 | |
| 	if len(labels) == 0 || len(job.RunsOn) == 0 {
 | |
| 		return false
 | |
| 	}
 | |
| 	labelSet := make(container.Set[string])
 | |
| 	labelSet.AddMultiple(labels...)
 | |
| 	return labelSet.IsSubset(job.RunsOn)
 | |
| }
 | |
| 
 | |
| func GetRunJobByID(ctx context.Context, id int64) (*ActionRunJob, error) {
 | |
| 	var job ActionRunJob
 | |
| 	has, err := db.GetEngine(ctx).Where("id=?", id).Get(&job)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	} else if !has {
 | |
| 		return nil, fmt.Errorf("run job with id %d: %w", id, util.ErrNotExist)
 | |
| 	}
 | |
| 
 | |
| 	return &job, nil
 | |
| }
 | |
| 
 | |
| func GetRunJobsByRunID(ctx context.Context, runID int64) ([]*ActionRunJob, error) {
 | |
| 	var jobs []*ActionRunJob
 | |
| 	if err := db.GetEngine(ctx).Where("run_id=?", runID).OrderBy("id").Find(&jobs); err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	return jobs, nil
 | |
| }
 | |
| 
 | |
| // All calls to UpdateRunJobWithoutNotification that change run.Status for any run from a not done status to a done status must call the ActionRunNowDone notification channel.
 | |
| // Use the wrapper function UpdateRunJob instead.
 | |
| func UpdateRunJobWithoutNotification(ctx context.Context, job *ActionRunJob, cond builder.Cond, cols ...string) (int64, error) {
 | |
| 	e := db.GetEngine(ctx)
 | |
| 
 | |
| 	sess := e.ID(job.ID)
 | |
| 	if len(cols) > 0 {
 | |
| 		sess.Cols(cols...)
 | |
| 	}
 | |
| 
 | |
| 	if cond != nil {
 | |
| 		sess.Where(cond)
 | |
| 	}
 | |
| 
 | |
| 	affected, err := sess.Update(job)
 | |
| 	if err != nil {
 | |
| 		return 0, err
 | |
| 	}
 | |
| 
 | |
| 	if affected == 0 || (!slices.Contains(cols, "status") && job.Status == 0) {
 | |
| 		return affected, nil
 | |
| 	}
 | |
| 
 | |
| 	if affected != 0 && slices.Contains(cols, "status") && job.Status.IsWaiting() {
 | |
| 		// if the status of job changes to waiting again, increase tasks version.
 | |
| 		if err := IncreaseTaskVersion(ctx, job.OwnerID, job.RepoID); err != nil {
 | |
| 			return 0, err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if job.RunID == 0 {
 | |
| 		var err error
 | |
| 		if job, err = GetRunJobByID(ctx, job.ID); err != nil {
 | |
| 			return 0, err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	{
 | |
| 		// Other goroutines may aggregate the status of the run and update it too.
 | |
| 		// So we need load the run and its jobs before updating the run.
 | |
| 		run, err := GetRunByID(ctx, job.RunID)
 | |
| 		if err != nil {
 | |
| 			return 0, err
 | |
| 		}
 | |
| 		jobs, err := GetRunJobsByRunID(ctx, job.RunID)
 | |
| 		if err != nil {
 | |
| 			return 0, err
 | |
| 		}
 | |
| 		run.Status = AggregateJobStatus(jobs)
 | |
| 		if run.Started.IsZero() && run.Status.IsRunning() {
 | |
| 			run.Started = timeutil.TimeStampNow()
 | |
| 		}
 | |
| 		if run.Stopped.IsZero() && run.Status.IsDone() {
 | |
| 			run.Stopped = timeutil.TimeStampNow()
 | |
| 		}
 | |
| 		// As the caller has to ensure the ActionRunNowDone notification is sent we can ignore doing so here.
 | |
| 		if err := UpdateRunWithoutNotification(ctx, run, "status", "started", "stopped"); err != nil {
 | |
| 			return 0, fmt.Errorf("update run %d: %w", run.ID, err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return affected, nil
 | |
| }
 | |
| 
 | |
| func AggregateJobStatus(jobs []*ActionRunJob) Status {
 | |
| 	allSuccessOrSkipped := len(jobs) != 0
 | |
| 	allSkipped := len(jobs) != 0
 | |
| 	var hasFailure, hasCancelled, hasWaiting, hasRunning, hasBlocked bool
 | |
| 	for _, job := range jobs {
 | |
| 		allSuccessOrSkipped = allSuccessOrSkipped && (job.Status == StatusSuccess || job.Status == StatusSkipped)
 | |
| 		allSkipped = allSkipped && job.Status == StatusSkipped
 | |
| 		hasFailure = hasFailure || job.Status == StatusFailure
 | |
| 		hasCancelled = hasCancelled || job.Status == StatusCancelled
 | |
| 		hasWaiting = hasWaiting || job.Status == StatusWaiting
 | |
| 		hasRunning = hasRunning || job.Status == StatusRunning
 | |
| 		hasBlocked = hasBlocked || job.Status == StatusBlocked
 | |
| 	}
 | |
| 	switch {
 | |
| 	case allSkipped:
 | |
| 		return StatusSkipped
 | |
| 	case allSuccessOrSkipped:
 | |
| 		return StatusSuccess
 | |
| 	case hasCancelled:
 | |
| 		return StatusCancelled
 | |
| 	case hasFailure:
 | |
| 		return StatusFailure
 | |
| 	case hasRunning:
 | |
| 		return StatusRunning
 | |
| 	case hasWaiting:
 | |
| 		return StatusWaiting
 | |
| 	case hasBlocked:
 | |
| 		return StatusBlocked
 | |
| 	default:
 | |
| 		return StatusUnknown // it shouldn't happen
 | |
| 	}
 | |
| }
 |