
Some checks are pending
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
/ release (push) Waiting to run
- Consider the following scenario: a private repository in an organization with a team that has no specific access to that repository. Members of that team are still able to visit the repository because of entries in the `access` table.
- Consider this specific scenario for the gathering of issues for project tables.
- Unit test added
- Resolves forgejo/forgejo#7217
- Ref: forgejo/forgejo#6843
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7270
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
(cherry picked from commit 72ee7f3b00
)
173 lines
6.9 KiB
Go
173 lines
6.9 KiB
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package issues_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/issues"
|
|
"code.gitea.io/gitea/models/organization"
|
|
"code.gitea.io/gitea/models/project"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/optional"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPrivateIssueProjects(t *testing.T) {
|
|
defer tests.AddFixtures("models/fixtures/PrivateIssueProjects/")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
t.Run("Organization project", func(t *testing.T) {
|
|
org := unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 3})
|
|
orgProject := unittest.AssertExistsAndLoadBean(t, &project.Project{ID: 1001, OwnerID: org.ID})
|
|
column := unittest.AssertExistsAndLoadBean(t, &project.Column{ID: 1001, ProjectID: orgProject.ID})
|
|
|
|
t.Run("Authenticated user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, user2, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 2)
|
|
assert.EqualValues(t, 16, issueList[0].ID)
|
|
assert.EqualValues(t, 6, issueList[1].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
})
|
|
|
|
t.Run("Anonymous user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, nil, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 1)
|
|
assert.EqualValues(t, 16, issueList[0].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, orgProject, nil, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, nil, org, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, nil, org, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
})
|
|
})
|
|
|
|
t.Run("User project", func(t *testing.T) {
|
|
userProject := unittest.AssertExistsAndLoadBean(t, &project.Project{ID: 1002, OwnerID: user2.ID})
|
|
column := unittest.AssertExistsAndLoadBean(t, &project.Column{ID: 1002, ProjectID: userProject.ID})
|
|
|
|
t.Run("Authenticated user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, user2, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 2)
|
|
assert.EqualValues(t, 7, issueList[0].ID)
|
|
assert.EqualValues(t, 1, issueList[1].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, userProject, user2, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, user2, nil, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, user2, nil, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
})
|
|
|
|
t.Run("Anonymous user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, nil, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 1)
|
|
assert.EqualValues(t, 1, issueList[0].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, userProject, nil, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, nil, nil, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, nil, nil, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestPrivateRepoProjects(t *testing.T) {
|
|
defer tests.AddFixtures("models/fixtures/TestPrivateRepoProjects/")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
org := unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 3})
|
|
orgProject := unittest.AssertExistsAndLoadBean(t, &project.Project{ID: 1001, OwnerID: org.ID})
|
|
column := unittest.AssertExistsAndLoadBean(t, &project.Column{ID: 1001, ProjectID: orgProject.ID})
|
|
|
|
t.Run("Partial access", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
user29 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 29})
|
|
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, user29, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 1)
|
|
assert.EqualValues(t, 6, issueList[0].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, orgProject, user29, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user29, org, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user29, org, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
})
|
|
|
|
t.Run("Full access", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, user2, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 2)
|
|
assert.EqualValues(t, 15, issueList[0].ID)
|
|
assert.EqualValues(t, 6, issueList[1].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
})
|
|
}
|