 40551de313
			
		
	
	
	40551de313
	
	
	
		
			
			Goals:
- speedup
- less flakiness
- best practices and more use
- documentation
config:
- sync ports in Makefile and playwright config
  (otherwise, some tests fail locally because they assert the full URL including the (wrong) port)
- even more generous timeouts
- limit workers to one again (because I finally understand how
  Playwright works)
- allow nested functions to group them together with the related test
all:
- deprecate waitForLoadState('networkidle')
  - it is discouraged as per https://playwright.dev/docs/api/class-page#page-wait-for-load-state
  - I could not find a usage that seems to require it actually (see
    added documentation in README)
  - adding an exception should be made explicitly
  - it does not do what you might expect anyway in most cases
- only log in when necessary
webauthn:
- verify that login is possible after disabling key
- otherwise, the cleanup was not necessary after the previous refactor to create a fresh user each
issue-sidebar / WIP toggle:
- split into smaller chunks
- restore original state first
- add missed assertion to fix race condition (not waiting
  before state was reached)
- explicitly toggle the state to detect mismatch earlier
issue-sidebar / labels:
- restore original state first
- better waiting for background request
		
	
			
		
			
				
	
	
		
			31 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
			
		
		
	
	
			31 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
| // @watch start
 | |
| // templates/repo/graph.tmpl
 | |
| // web_src/css/features/gitgraph.css
 | |
| // web_src/js/features/repo-graph.js
 | |
| // @watch end
 | |
| 
 | |
| import {expect} from '@playwright/test';
 | |
| import {test} from './utils_e2e.ts';
 | |
| 
 | |
| test('Commit graph overflow', async ({page}) => {
 | |
|   await page.goto('/user2/diff-test/graph');
 | |
|   await expect(page.getByRole('button', {name: 'Mono'})).toBeInViewport({ratio: 1});
 | |
|   await expect(page.getByRole('button', {name: 'Color'})).toBeInViewport({ratio: 1});
 | |
|   await expect(page.locator('.selection.search.dropdown')).toBeInViewport({ratio: 1});
 | |
| });
 | |
| 
 | |
| test('Switch branch', async ({page}) => {
 | |
|   const response = await page.goto('/user2/repo1/graph');
 | |
|   expect(response?.status()).toBe(200);
 | |
| 
 | |
|   await page.click('#flow-select-refs-dropdown');
 | |
|   const input = page.locator('#flow-select-refs-dropdown');
 | |
|   await input.pressSequentially('develop', {delay: 50});
 | |
|   await input.press('Enter');
 | |
| 
 | |
|   await page.waitForLoadState();
 | |
| 
 | |
|   await expect(page.locator('#loading-indicator')).toBeHidden();
 | |
|   await expect(page.locator('#rel-container')).toBeVisible();
 | |
|   await expect(page.locator('#rev-container')).toBeVisible();
 | |
| });
 |