 99d697263f
			
		
	
	
	99d697263f
	
	
	
		
			
			This PR replaces unnecessary calls to formatting functions (`fmt.Printf`, `fmt.Errorf`, ...) by non-formatting equivalents. Resolves #7967 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7994 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: chavacava <chavacava@noreply.codeberg.org> Co-committed-by: chavacava <chavacava@noreply.codeberg.org>
		
			
				
	
	
		
			362 lines
		
	
	
	
		
			11 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			362 lines
		
	
	
	
		
			11 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // Copyright 2024 The Forgejo Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package issue
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"time"
 | |
| 
 | |
| 	activities_model "forgejo.org/models/activities"
 | |
| 	"forgejo.org/models/db"
 | |
| 	issues_model "forgejo.org/models/issues"
 | |
| 	access_model "forgejo.org/models/perm/access"
 | |
| 	project_model "forgejo.org/models/project"
 | |
| 	repo_model "forgejo.org/models/repo"
 | |
| 	system_model "forgejo.org/models/system"
 | |
| 	user_model "forgejo.org/models/user"
 | |
| 	"forgejo.org/modules/git"
 | |
| 	"forgejo.org/modules/log"
 | |
| 	"forgejo.org/modules/storage"
 | |
| 	"forgejo.org/modules/timeutil"
 | |
| 	notify_service "forgejo.org/services/notify"
 | |
| )
 | |
| 
 | |
| // NewIssue creates new issue with labels for repository.
 | |
| func NewIssue(ctx context.Context, repo *repo_model.Repository, issue *issues_model.Issue, labelIDs []int64, uuids []string, assigneeIDs []int64) error {
 | |
| 	// Check if the user is not blocked by the repo's owner.
 | |
| 	if user_model.IsBlocked(ctx, repo.OwnerID, issue.PosterID) {
 | |
| 		return user_model.ErrBlockedByUser
 | |
| 	}
 | |
| 
 | |
| 	if err := issues_model.NewIssue(ctx, repo, issue, labelIDs, uuids); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	for _, assigneeID := range assigneeIDs {
 | |
| 		if _, err := AddAssigneeIfNotAssigned(ctx, issue, issue.Poster, assigneeID, true); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	mentions, err := issues_model.FindAndUpdateIssueMentions(ctx, issue, issue.Poster, issue.Content)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	notify_service.NewIssue(ctx, issue, mentions)
 | |
| 	if len(issue.Labels) > 0 {
 | |
| 		notify_service.IssueChangeLabels(ctx, issue.Poster, issue, issue.Labels, nil)
 | |
| 	}
 | |
| 	if issue.Milestone != nil {
 | |
| 		notify_service.IssueChangeMilestone(ctx, issue.Poster, issue, 0)
 | |
| 	}
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // ChangeTitle changes the title of this issue, as the given user.
 | |
| func ChangeTitle(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, title string) error {
 | |
| 	oldTitle := issue.Title
 | |
| 
 | |
| 	if oldTitle == title {
 | |
| 		return nil
 | |
| 	}
 | |
| 
 | |
| 	if err := issue.LoadRepo(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if user_model.IsBlockedMultiple(ctx, []int64{issue.PosterID, issue.Repo.OwnerID}, doer.ID) {
 | |
| 		return user_model.ErrBlockedByUser
 | |
| 	}
 | |
| 
 | |
| 	// If the issue was reported as abusive, a shadow copy should be created before first update.
 | |
| 	if err := issues_model.IfNeededCreateShadowCopyForIssue(ctx, issue); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	issue.Title = title
 | |
| 	if err := issues_model.ChangeIssueTitle(ctx, issue, doer, oldTitle); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	var reviewNotifers []*ReviewRequestNotifier
 | |
| 	if issue.IsPull && issues_model.HasWorkInProgressPrefix(oldTitle) && !issues_model.HasWorkInProgressPrefix(title) {
 | |
| 		var err error
 | |
| 		reviewNotifers, err = PullRequestCodeOwnersReview(ctx, issue, issue.PullRequest)
 | |
| 		if err != nil {
 | |
| 			log.Error("PullRequestCodeOwnersReview: %v", err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	notify_service.IssueChangeTitle(ctx, doer, issue, oldTitle)
 | |
| 	ReviewRequestNotify(ctx, issue, issue.Poster, reviewNotifers)
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // ChangeIssueRef changes the branch of this issue, as the given user.
 | |
| func ChangeIssueRef(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, ref string) error {
 | |
| 	oldRef := issue.Ref
 | |
| 	issue.Ref = ref
 | |
| 
 | |
| 	if err := issues_model.ChangeIssueRef(ctx, issue, doer, oldRef); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	notify_service.IssueChangeRef(ctx, doer, issue, oldRef)
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // UpdateAssignees is a helper function to add or delete one or multiple issue assignee(s)
 | |
| // Deleting is done the GitHub way (quote from their api documentation):
 | |
| // https://developer.github.com/v3/issues/#edit-an-issue
 | |
| // "assignees" (array): Logins for Users to assign to this issue.
 | |
| // Pass one or more user logins to replace the set of assignees on this Issue.
 | |
| // Send an empty array ([]) to clear all assignees from the Issue.
 | |
| func UpdateAssignees(ctx context.Context, issue *issues_model.Issue, oneAssignee string, multipleAssignees []string, doer *user_model.User) (err error) {
 | |
| 	var allNewAssignees []*user_model.User
 | |
| 
 | |
| 	// Keep the old assignee thingy for compatibility reasons
 | |
| 	if oneAssignee != "" {
 | |
| 		// Prevent double adding assignees
 | |
| 		var isDouble bool
 | |
| 		for _, assignee := range multipleAssignees {
 | |
| 			if assignee == oneAssignee {
 | |
| 				isDouble = true
 | |
| 				break
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if !isDouble {
 | |
| 			multipleAssignees = append(multipleAssignees, oneAssignee)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Loop through all assignees to add them
 | |
| 	for _, assigneeName := range multipleAssignees {
 | |
| 		assignee, err := user_model.GetUserByName(ctx, assigneeName)
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 
 | |
| 		allNewAssignees = append(allNewAssignees, assignee)
 | |
| 	}
 | |
| 
 | |
| 	// Delete all old assignees not passed
 | |
| 	if err = DeleteNotPassedAssignee(ctx, issue, doer, allNewAssignees); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// Add all new assignees
 | |
| 	// Update the assignee. The function will check if the user exists, is already
 | |
| 	// assigned (which he shouldn't as we deleted all assignees before) and
 | |
| 	// has access to the repo.
 | |
| 	for _, assignee := range allNewAssignees {
 | |
| 		// Extra method to prevent double adding (which would result in removing)
 | |
| 		_, err = AddAssigneeIfNotAssigned(ctx, issue, doer, assignee.ID, true)
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return err
 | |
| }
 | |
| 
 | |
| // DeleteIssue deletes an issue
 | |
| func DeleteIssue(ctx context.Context, doer *user_model.User, gitRepo *git.Repository, issue *issues_model.Issue) error {
 | |
| 	// load issue before deleting it
 | |
| 	if err := issue.LoadAttributes(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if err := issue.LoadPullRequest(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// delete entries in database
 | |
| 	if err := deleteIssue(ctx, issue); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// delete pull request related git data
 | |
| 	if issue.IsPull && gitRepo != nil {
 | |
| 		if err := gitRepo.RemoveReference(fmt.Sprintf("%s%d/head", git.PullPrefix, issue.PullRequest.Index)); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// If the Issue is pinned, we should unpin it before deletion to avoid problems with other pinned Issues
 | |
| 	if issue.IsPinned() {
 | |
| 		if err := issue.Unpin(ctx, doer); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	notify_service.DeleteIssue(ctx, doer, issue)
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // AddAssigneeIfNotAssigned adds an assignee only if he isn't already assigned to the issue.
 | |
| // Also checks for access of assigned user
 | |
| func AddAssigneeIfNotAssigned(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, assigneeID int64, notify bool) (comment *issues_model.Comment, err error) {
 | |
| 	assignee, err := user_model.GetUserByID(ctx, assigneeID)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	// Check if the user is already assigned
 | |
| 	isAssigned, err := issues_model.IsUserAssignedToIssue(ctx, issue, assignee)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	if isAssigned {
 | |
| 		// nothing to to
 | |
| 		return nil, nil
 | |
| 	}
 | |
| 
 | |
| 	valid, err := access_model.CanBeAssigned(ctx, assignee, issue.Repo, issue.IsPull)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	if !valid {
 | |
| 		return nil, repo_model.ErrUserDoesNotHaveAccessToRepo{UserID: assigneeID, RepoName: issue.Repo.Name}
 | |
| 	}
 | |
| 
 | |
| 	if notify {
 | |
| 		_, comment, err = ToggleAssigneeWithNotify(ctx, issue, doer, assigneeID)
 | |
| 		return comment, err
 | |
| 	}
 | |
| 	_, comment, err = issues_model.ToggleIssueAssignee(ctx, issue, doer, assigneeID)
 | |
| 	return comment, err
 | |
| }
 | |
| 
 | |
| // GetRefEndNamesAndURLs retrieves the ref end names (e.g. refs/heads/branch-name -> branch-name)
 | |
| // and their respective URLs.
 | |
| func GetRefEndNamesAndURLs(issues []*issues_model.Issue, repoLink string) (map[int64]string, map[int64]string) {
 | |
| 	issueRefEndNames := make(map[int64]string, len(issues))
 | |
| 	issueRefURLs := make(map[int64]string, len(issues))
 | |
| 	for _, issue := range issues {
 | |
| 		if issue.Ref != "" {
 | |
| 			issueRefEndNames[issue.ID] = git.RefName(issue.Ref).ShortName()
 | |
| 			issueRefURLs[issue.ID] = git.RefURL(repoLink, issue.Ref)
 | |
| 		}
 | |
| 	}
 | |
| 	return issueRefEndNames, issueRefURLs
 | |
| }
 | |
| 
 | |
| // deleteIssue deletes the issue
 | |
| func deleteIssue(ctx context.Context, issue *issues_model.Issue) error {
 | |
| 	ctx, committer, err := db.TxContext(ctx)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	defer committer.Close()
 | |
| 
 | |
| 	e := db.GetEngine(ctx)
 | |
| 
 | |
| 	// If the issue was reported as abusive, a shadow copy should be created before deletion.
 | |
| 	if err := issues_model.IfNeededCreateShadowCopyForIssue(ctx, issue); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if _, err := e.ID(issue.ID).NoAutoCondition().Delete(issue); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// update the total issue numbers
 | |
| 	if err := repo_model.UpdateRepoIssueNumbers(ctx, issue.RepoID, issue.IsPull, false); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	// if the issue is closed, update the closed issue numbers
 | |
| 	if issue.IsClosed {
 | |
| 		if err := repo_model.UpdateRepoIssueNumbers(ctx, issue.RepoID, issue.IsPull, true); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if err := issues_model.UpdateMilestoneCounters(ctx, issue.MilestoneID); err != nil {
 | |
| 		return fmt.Errorf("error updating counters for milestone id %d: %w",
 | |
| 			issue.MilestoneID, err)
 | |
| 	}
 | |
| 
 | |
| 	if err := activities_model.DeleteIssueActions(ctx, issue.RepoID, issue.ID, issue.Index); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// find attachments related to this issue and remove them
 | |
| 	if err := issue.LoadAttributes(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	for i := range issue.Attachments {
 | |
| 		system_model.RemoveStorageWithNotice(ctx, storage.Attachments, "Delete issue attachment", issue.Attachments[i].RelativePath())
 | |
| 	}
 | |
| 
 | |
| 	// delete all database data still assigned to this issue
 | |
| 	if err := db.DeleteBeans(ctx,
 | |
| 		&issues_model.ContentHistory{IssueID: issue.ID},
 | |
| 		&issues_model.Comment{IssueID: issue.ID},
 | |
| 		&issues_model.IssueLabel{IssueID: issue.ID},
 | |
| 		&issues_model.IssueDependency{IssueID: issue.ID},
 | |
| 		&issues_model.IssueAssignees{IssueID: issue.ID},
 | |
| 		&issues_model.IssueUser{IssueID: issue.ID},
 | |
| 		&activities_model.Notification{IssueID: issue.ID},
 | |
| 		&issues_model.Reaction{IssueID: issue.ID},
 | |
| 		&issues_model.IssueWatch{IssueID: issue.ID},
 | |
| 		&issues_model.Stopwatch{IssueID: issue.ID},
 | |
| 		&issues_model.TrackedTime{IssueID: issue.ID},
 | |
| 		&project_model.ProjectIssue{IssueID: issue.ID},
 | |
| 		&repo_model.Attachment{IssueID: issue.ID},
 | |
| 		&issues_model.PullRequest{IssueID: issue.ID},
 | |
| 		&issues_model.Comment{RefIssueID: issue.ID},
 | |
| 		&issues_model.IssueDependency{DependencyID: issue.ID},
 | |
| 		&issues_model.Comment{DependentIssueID: issue.ID},
 | |
| 	); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	return committer.Commit()
 | |
| }
 | |
| 
 | |
| // Set the UpdatedUnix date and the NoAutoTime field of an Issue if a non
 | |
| // nil 'updated' time is provided
 | |
| //
 | |
| // In order to set a specific update time, the DB will be updated with
 | |
| // NoAutoTime(). A 'NoAutoTime' boolean field in the Issue struct is used to
 | |
| // propagate down to the DB update calls the will to apply autoupdate or not.
 | |
| func SetIssueUpdateDate(ctx context.Context, issue *issues_model.Issue, updated *time.Time, doer *user_model.User) error {
 | |
| 	issue.NoAutoTime = false
 | |
| 	if updated == nil {
 | |
| 		return nil
 | |
| 	}
 | |
| 
 | |
| 	if err := issue.LoadRepo(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// Check if the poster is allowed to set an update date
 | |
| 	perm, err := access_model.GetUserRepoPermission(ctx, issue.Repo, doer)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if !perm.IsAdmin() && !perm.IsOwner() {
 | |
| 		return errors.New("user needs to have admin or owner right")
 | |
| 	}
 | |
| 
 | |
| 	// A simple guard against potential inconsistent calls
 | |
| 	updatedUnix := timeutil.TimeStamp(updated.Unix())
 | |
| 	if updatedUnix < issue.CreatedUnix || updatedUnix > timeutil.TimeStampNow() {
 | |
| 		return errors.New("unallowed update date")
 | |
| 	}
 | |
| 
 | |
| 	issue.UpdatedUnix = updatedUnix
 | |
| 	issue.NoAutoTime = true
 | |
| 
 | |
| 	return nil
 | |
| }
 |