Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Re-enable unit test active_transactions.confirm_new (#4438)

Browse source 
I am renabling this test. It is a trivial test and I can see no reason why
it should not work. If it does not work, then we need to find out why.
This commit is contained in:
Dimitrios Siganos 2024-02-19 01:34:19 +00:00
commit 8d08259cbb
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
nano/core_test/active_transactions.cpp
View file

@ -1041,10 +1041,7 @@ TEST (active_transactions, confirmation_consistency)
}
}
// Test disabled because it's failing intermittently.
// PR in which it got disabled: https://github.com/nanocurrency/nano-node/pull/3629
// Issue for investigating it: https://github.com/nanocurrency/nano-node/issues/3634
TEST (active_transactions, DISABLED_confirm_new)
TEST (active_transactions, confirm_new)
{
nano::test::system system (1);
auto & node1 = *system.nodes[0];
@ -1063,7 +1060,8 @@ TEST (active_transactions, DISABLED_confirm_new)
// Let node2 know about the block
ASSERT_TIMELY (5s, node2.block (send->hash ()));
// Wait confirmation
ASSERT_TIMELY (5s, node1.ledger.cache.cemented_count == 2 && node2.ledger.cache.cemented_count == 2);
ASSERT_TIMELY (5s, node1.ledger.cache.cemented_count == 2);
ASSERT_TIMELY (5s, node2.ledger.cache.cemented_count == 2);
}
// Ensures votes are tallied on election::publish even if no vote is inserted through inactive_votes_cache