dn724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Warn if control is enabled with non-local bind address (#2401)

Browse source
This commit is contained in:
cryptocode 2019-11-11 15:44:49 +01:00 • committed by GitHub
commit 9b30b399b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
nano/rpc/rpc.cpp
View file

@ -29,6 +29,12 @@ nano::rpc::~rpc ()
void nano::rpc::start () void nano::rpc::start ()
{ {
auto endpoint (boost::asio::ip::tcp::endpoint (config.address, config.port)); auto endpoint (boost::asio::ip::tcp::endpoint (config.address, config.port));
if (!endpoint.address ().is_loopback () && config.enable_control)
{
auto warning = boost::str (boost::format ("WARNING: control-level RPCs are enabled on non-local address %1%, potentially allowing wallet access outside local computer") % endpoint.address ().to_string ());
std::cout << warning << std::endl;
logger.always_log (warning);
}
acceptor.open (endpoint.protocol ()); acceptor.open (endpoint.protocol ());
acceptor.set_option (boost::asio::ip::tcp::acceptor::reuse_address (true)); acceptor.set_option (boost::asio::ip::tcp::acceptor::reuse_address (true));